-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add num_floors_underground #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skmoore Would you mind adding one counterexample that has an invalid value for num_floors_underground
and uses the ext_expected_exception
property to verify that the right validation exception is generated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
351356a
I added a counter example, but I cannot generate the proper expected exception? |
Can you help me understand what actions you did, and how the actual result different from your expectation? The way I usually do this is:
|
Description
Adds a
num_floors_underground
flag for buildings that have one or more floors below ground level. This will allow for more accurate 3d representations of buildings that are partially or fully below ground. This should map to thebuilding:levels:underground
tag from OSM.Reference
List of relevant links to GitHub issues, PRs, and other documentation.
TODO.
Add relevant examples.
Add relevant counterexamples.
Update any counterexamples that became obsolete. For example, if a counterexample uses property
A
but is not intended to test propertyA
's validity, and you made a schema change that invalidates propertyA
in that counterexample, fix the counterexample to align it with your schema change.Update in-schema documentation using plain English written in complete sentences, if an update is required.
Update Docusaurus documentation, if an update is required.
Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.
Documentation Website
Update the hyperlink below to put the pull request number in.
[Docs preview for this PR.](https://dfhx9f55j8eg5.cloudfront.net/pr/<PUT THE PR # HERE>)